Re: [RESEND][PATCH v2] dmaengine: bcm2835: Add slave dma support

From: Vinod Koul
Date: Fri Dec 18 2015 - 03:01:04 EST


On Fri, Dec 18, 2015 at 08:27:52AM +0100, Martin Sperl wrote:
>
> > On 18.12.2015, at 07:05, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:

> > Most of this part is common with the cyclic and seems copy paste. Can we
> > use common routine to do common work please
>
> I agree - can have a look - the big question is: how would I document the
> individual changes by Gellert Weisz and myself correctly?
> * just a single patch with an attribution tag (which?) or just a commit message?
> * Patchset with 2 patches: the original by Gellert Weisz (this)
> plus the modification to consolidate the code above?

There are lot of patches were original contributors moved away. In the change
log please say original written by <> and modified for upstream by you.

That way you retain credit for original changes done

Thanks
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/