Re: [PATCH 3/3] ata: sata_dwc_460ex: get rid of global data

[Måns Rullgård]

Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:

> On Thu, 2015-12-17 at 15:19 +0000, Måns Rullgård wrote:
>> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
>> 
>> > On Tue, 2015-12-15 at 23:25 +0000, Mans Rullgard wrote:
>> > > This moves all global data into the driver private struct, thus
>> > > permitting multiple devices of this type to be used.
>> > > 
>> > 
>> > Nice!
>> > 
>> > Btw, last time Linus complained about new warnings. Most of them I
>> > have
>> > fixed when moved to external DMA driver. Leftovers IIRC are related
>> > to
>> > address space. Are you going to fix them? Otherwise it might be a
>> > headache for him again with strong wording to our address I
>> > suppose.
>> 
>> There are some issues with __iomem annotations.  Is that the warnings
>> you refer to?  I'm not getting any regular compiler warnings.
>> 
>
> I guess I got them because I'am checking sparse warnings as well.
>
> There is the original Linus' complain.
> http://permalink.gmane.org/gmane.linux.ide/59391

He's right, those casts are ugly and possibly wrong.  I was thinking of
cleaning it up, but first I wanted to get it working at all with my
hardware.

-- 
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/