Re: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar

From: Geert Uytterhoeven
Date: Thu Dec 17 2015 - 08:41:23 EST


On Thu, Dec 17, 2015 at 2:30 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>> + /* Wait until we are in L1 */
>> + while (!(val & L1FAEG))
>> + val = rcar_pci_read_reg(pcie, PMSR);
>
> No timeout?

And no cpu_relax() in each iteration.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/