Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node

From: chenfeng
Date: Wed Dec 16 2015 - 22:34:56 EST

Mark,
+- regulator-vset-regs: Voltage set register offset.
+- regulator-vset-mask: voltage set control mask.
+- regulator-n-vol: The num of support voltages.
+- regulator-vset-table: The table of support voltages.

> Why is this in the binding? This is a binding for a specific device,
> there is no point in putting all these data tables in the DT - it just
> bloats the DT and makes it harder for us to enhance our support for this
> device in the future.

You mentioned in previous version,I I have some questions for it.

This regulator-vset-regs etc are vendor specific describe. The hi655x PMIC
is a series of chips. They all have this value, but the offset may be different.
And we can generate the dts file from excel which is defined by SOC.

I think the dts is designed to distinguish different platform. If we hard code this
in files, it may be also different to use as common in next chip version.

I will appreciate it if you can give me some suggestions.


On 2015/12/15 20:54, Chen Feng wrote:
> Add dts node for hi665x MFD and regulator driver
>
> Signed-off-by: Chen Feng <puck.chen@xxxxxxxxxxxxx>
> Signed-off-by: Fei Wang <w.f@xxxxxxxxxx>
> Tested-by: Xinwei Kong <kong.kongxinwei@xxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 178 ++++++++++++++++++++++++++++++
> 1 file changed, 178 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 82d2488..5f98a72 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -208,5 +208,183 @@
> clock-names = "uartclk", "apb_pclk";
> status = "disabled";
> };
> + pmic: pmic@F8000000 {
> + compatible = "hisilicon,hi655x-pmic";
> + reg = <0x0 0xf8000000 0x0 0x1000>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + pmic-gpios = <&gpio_pmu_irq_n>;
> + status = "okay";
> + ldo2: regulator@a21 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo2";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <3200000>;
> + regulator-valid-modes-mask = <0x02>;
> + regulator-enable-ramp-delay = <120>;
> + regulator-ctrl-regs = <0x029 0x02a 0x02b>;
> + regulator-ctrl-mask = <0x1>;
> + regulator-vset-regs = <0x072>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <2500000>,<2600000>,
> + <2700000>,<2800000>,
> + <2900000>,<3000000>,
> + <3100000>,<3200000>;
> + };
> + ldo7: regulator@a26 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo7";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-valid-modes-mask = <0x0a>;
> + regulator-enable-ramp-delay = <120>;
> + regulator-ctrl-regs = <0x029 0x02a 0x02b>;
> + regulator-ctrl-mask = <0x6>;
> + regulator-vset-regs = <0x078>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <1800000>,<1850000>,
> + <2850000>,<2900000>,
> + <3000000>,<3100000>,
> + <3200000>,<3300000>;
> + };
> + ldo10: regulator@a29 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo10";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-valid-modes-mask = <0x0a>;
> + regulator-enable-ramp-delay = <360>;
> + regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
> + regulator-ctrl-mask = <0x1>;
> + regulator-vset-regs = <0x07b>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <1800000>,<1850000>,
> + <1900000>,<2750000>,
> + <2800000>,<2850000>,
> + <2900000>,<3000000>;
> + };
> + ldo13: regulator@a32 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo13";
> + regulator-min-microvolt = <1600000>;
> + regulator-max-microvolt = <1950000>;
> + regulator-enable-ramp-delay = <120>;
> + regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
> + regulator-ctrl-mask = <0x4>;
> + regulator-vset-regs = <0x07e>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <1600000>,<1650000>,
> + <1700000>,<1750000>,
> + <1800000>,<1850000>,
> + <1900000>,<1950000>;
> + };
> + ldo14: regulator@a33 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo14";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <3200000>;
> + regulator-enable-ramp-delay = <120>;
> + regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
> + regulator-ctrl-mask = <0x5>;
> + regulator-vset-regs = <0x07f>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <2500000>,<2600000>,
> + <2700000>,<2800000>,
> + <2900000>,<3000000>,
> + <3100000>,<3200000>;
> + };
> + ldo15: regulator@a34 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo15";
> + regulator-min-microvolt = <1600000>;
> + regulator-max-microvolt = <1950000>;
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-enable-ramp-delay = <120>;
> + regulator-ctrl-regs = <0x02c 0x02d 0x02e>;
> + regulator-ctrl-mask = <0x6>;
> + regulator-vset-regs = <0x080>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <1600000>,<1650000>,
> + <1700000>,<1750000>,
> + <1800000>,<1850000>,
> + <1900000>,<1950000>;
> + };
> + ldo17: regulator@a36 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo17";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <3200000>;
> + regulator-enable-ramp-delay = <120>;
> + regulator-ctrl-regs = <0x02f 0x030 0x031>;
> + regulator-ctrl-mask = <0x0>;
> + regulator-vset-regs = <0x082>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <2500000>,<2600000>,
> + <2700000>,<2800000>,
> + <2900000>,<3000000>,
> + <3100000>,<3200000>;
> + };
> + ldo19: regulator@a38 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo19";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-enable-ramp-delay = <360>;
> + regulator-ctrl-regs = <0x02f 0x030 0x031>;
> + regulator-ctrl-mask = <0x2>;
> + regulator-vset-regs = <0x084>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <1800000>,<1850000>,
> + <1900000>,<2750000>,
> + <2800000>,<2850000>,
> + <2900000>,<3000000>;
> + };
> + ldo21: regulator@a40 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo21";
> + regulator-min-microvolt = <1650000>;
> + regulator-max-microvolt = <2000000>;
> + regulator-always-on;
> + regulator-valid-modes-mask = <0x02>;
> + regulator-enable-ramp-delay = <120>;
> + regulator-ctrl-regs = <0x02f 0x030 0x031>;
> + regulator-ctrl-mask = <0x4>;
> + regulator-vset-regs = <0x086>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <1650000>,<1700000>,
> + <1750000>,<1800000>,
> + <1850000>,<1900000>,
> + <1950000>,<2000000>;
> + };
> + ldo22: regulator@a41 {
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo22";
> + regulator-min-microvolt = <900000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-boot-on;
> + regulator-always-on;
> + regulator-valid-modes-mask = <0x02>;
> + regulator-enable-ramp-delay = <120>;
> + regulator-ctrl-regs = <0x02f 0x030 0x031>;
> + regulator-ctrl-mask = <0x5>;
> + regulator-vset-regs = <0x087>;
> + regulator-vset-mask = <0x7>;
> + regulator-n-vol = <8>;
> + regulator-vset-table = <900000>,<1000000>,
> + <1050000>,<1100000>,
> + <1150000>,<1175000>,
> + <1185000>,<1200000>;
> + };
> + };
> };
> };
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/