Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

From: Michael Ellerman
Date: Mon Dec 14 2015 - 05:00:52 EST


On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote:
> On Tue, 08 Dec 2015 08:02:15 +1100
> Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote:
> > > > + TP_CONDITION(cpu_online(smp_processor_id())),
> > > > +
> >
> > This should probably be some kind of __raw version though, hcalls can
> > be called in contexts where the debug stuff in smp_processor_id() isn't
> > safe (or preempt enabled).
> >
>
> OK, then that needs to be updated.

Denis, please respin with raw_smp_processor_id().

cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/