Re: [PATCH 2/2] mfd: arizona: Update binding docs for selecting mono/stereo outputs

From: Rob Herring
Date: Fri Dec 11 2015 - 12:34:04 EST


On Fri, Dec 11, 2015 at 10:28:23AM +0000, Charles Keepax wrote:
> Update the device tree binding documentation to include the wlf,out-mono
> property that is used to specify whether each output is a mono or stereo
> output.

You just added this binding and updating it already? While we may like
kernel changes incremental, we don't like bindings evolving any more
than necessary.

> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 2b6ccdb..489dd07 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -65,6 +65,10 @@ Optional properties:
> that have not been specified are set to 0 by default. Entries are:
> <IN1, IN2, IN3, IN4> (wm5102, wm5110, wm8280, wm8997)
> <IN1A, IN2A, IN1B, IN2B> (wm8998, wm1814)
> + - wlf,out-mono : A boolean indicating whether each output is mono or stereo.
> + A non-zero value indicates a mono output. If present, the number of values
> + should be less than or equal to the number of outputs, if less values are
> + supplied the additional outputs will be treated as stereo.

How do you know which outputs are which with a variable number?

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/