Re: [PATCH 1/2] Input: add touchscreen bindings for TS-4800

From: Rob Herring
Date: Thu Dec 10 2015 - 22:40:08 EST


On Thu, Dec 10, 2015 at 11:11:11AM -0500, Damien Riegel wrote:
> Add bindings for the TS-4800 touchscreen.
>
> Signed-off-by: Damien Riegel <damien.riegel@xxxxxxxxxxxxxxxxxxxx>

Generally, there are other properties needed from the common touchscreen
binding. You don't need any of those here?

Otherwise,

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> ---
> .../devicetree/bindings/input/touchscreen/ts4800-ts.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ts4800-ts.txt
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ts4800-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/ts4800-ts.txt
> new file mode 100644
> index 0000000..63282fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/ts4800-ts.txt
> @@ -0,0 +1,12 @@
> +* TS-4800 Touchscreen bindings
> +
> +Required properties:
> +- compatible: must be "technologic,ts4800-ts"
> +- reg: physical base address of the controller and length of memory mapped
> + region.
> +- syscon: phandle / integers array that points to the syscon node which
> + describes the FPGA's syscon registers.
> + - phandle to FPGA's syscon
> + - offset to the touchscreen register
> + - offset to the touchscreen enable bit
> +
> --
> 2.5.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/