Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

[Stefan Schmidt]

Hello.

On 10/12/15 19:16, Marcel Holtmann wrote:
> Hi Stefan,
>
> > > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > > > Date: Mon, 16 Nov 2015 13:50:23 +0100
> > > >
> > > > The kfree_skb() function tests whether its argument is NULL and then
> > > > returns immediately. Thus the test around the call is not needed.
> > > >
> > > > This issue was detected by using the Coccinelle software.
> > > >
> > > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > > > ---
> > > > drivers/net/ieee802154/atusb.c | 3 +--
> > > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
> > > > index 199a94a..b1cd865 100644
> > > > --- a/drivers/net/ieee802154/atusb.c
> > > > +++ b/drivers/net/ieee802154/atusb.c
> > > > @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
> > > >          urb = usb_get_from_anchor(&atusb->idle_urbs);
> > > >          if (!urb)
> > > >              break;
> > > > -        if (urb->context)
> > > > -            kfree_skb(urb->context);
> > > > +        kfree_skb(urb->context);
> > > >          usb_free_urb(urb);
> > > >      }
> > > > }
> > > Acked-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxx>
> >
> > You got the original patch and my ACK on this one or would you prefer me to resend it again?
> this slipped through, but now it does no longer apply.
>
> Applying: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"
> error: patch failed: drivers/net/ieee802154/atusb.c:310
> error: drivers/net/ieee802154/atusb.c: patch does not apply
> Patch failed at 0001 ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

Not good. I did another resend, this one applied, compiled and worked 
fine for me. You will be in the to line.

regards
Stefan Schmidt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/