Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol

From: Robert Jarzmik
Date: Thu Dec 10 2015 - 12:31:57 EST


Linus Walleij <linus.walleij@xxxxxxxxxx> writes:

>> - the GPDR (gpio direction register) shared access bothers me a bit
>
> How is it shared and between what users?
It's shared between the pin controller and the gpio controller.

The odd thing with the pxa architecture is that the GPDR bit selects between 2
different alternate functions, even when the pin is not a GPIO. Strange design,
isn't it ?

As a consequence, both the gpio driver and pinctrl have to modify it, for
different purposes :
- pinctrl will modify it to select a specific alternate function
- gpio driver will modify it when the pin is a GPIO, to modify its direction.

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/