Re: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support

[Suravee Suthikulanit]

On 12/9/2015 12:16 PM, Marc Zyngier wrote:
> > > > diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
> > > > >>>[...]
> > > > >>>@@ -359,6 +368,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode,
> > > > >>>
> > > > >>>   	if (to_of_node(fwnode))
> > > > >>>   		name = to_of_node(fwnode)->name;
> > > > >>>+	else
> > > > >>>+		name = irq_domain_get_irqchip_fwnode_name(fwnode);
> > > >>
> > > >>Don't bother with that, the name associated with the domain is
> > > >>absolutely meaningless. You are already printing the frame address,
> > > >>which is enough to identify it, should someone need to debug this.
> > > >>
> > > >>Drop the name from the previous patch as well, and that will make one
> > > >>less difference to care about. Patch #3 can die as well.
> > > >>
> > >
> > >Ok. I'll just leave them blank (i.e. const char *name ="")
> No, just remove name altogether. Nobody reads that anyway, and if they
> want to find out, there is the address that's clear enough.
>
> Thanks,
>
> 	M.

Ok.
Suravee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/