Re: [PATCH 10/34] x86, pkeys: arch-specific protection bitsy

[Thomas Gleixner]

On Tue, 8 Dec 2015, Thomas Gleixner wrote:
> On Tue, 8 Dec 2015, Dave Hansen wrote:
> 
> > Here's how it looks with the suggested modifications.
> > 
> > Whatever compiler wonkiness I was seeing is gone now, so I've used the
> > most straightforward version of the shifts.
> 
> > +        * gcc generates better code if we do this rather than:
> > +        * pkey = (flags & mask) >> shift
> > +        */
> > +       pkey = (vma->vm_flags & vma_pkey_mask) >> VM_PKEY_SHIFT;
> 
> ROTFL!

Other than that silly comment, it's way better than before.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/