Re: [PATCH v3 2/4] clk: bcm2835: Support for clock parent selection

From: Eric Anholt
Date: Mon Dec 07 2015 - 20:32:16 EST


Remi Pommarel <repk@xxxxxxxxxxxx> writes:

> Some bcm2835 clocks used by hardware (like "PWM" or "H264") can have multiple
> parent clocks. These clocks divide the rate of a parent which can be selected by
> setting the proper bits in the clock control register.
>
> Previously all these parents where handled by a mux clock. But a mux clock
> cannot be used because updating clock control register to select parent needs a
> password to be xor'd with the parent index.
>
> This patch get rid of mux clock and make these clocks handle their own parent,
> allowing them to select the one to use.

I see, you use the new flag now in this patch. I take back the comment
on the previous patch.

Patches 1-3 are:

Reviewed-by: Eric Anholt <eric@xxxxxxxxxx>

and I think they're ready to go in the clock tree, even while the DT for
setting up the bcm2835-pwm driver is being reviewed on the DT list.

Attachment: signature.asc
Description: PGP signature