Re: [PATCH 2/3] Add support for monitoring gpio switches

[Martyn Welch]

On 04/12/15 18:57, Greg Kroah-Hartman wrote:
> On Fri, Dec 04, 2015 at 05:31:14PM +0000, Martyn Welch wrote:
> > Select Chromebooks have gpio attached to switches used to cause the
> > firmware to enter alternative modes of operation and/or control other
> > device characteristics (such as write protection on flash devices). This
> > patch adds a driver that exposes a read-only interface to allow these
> > signals to be read from user space.
> >
> > This functionality has been generalised to provide support for any device
> > with device tree support which needs to identify a gpio as being used for a
> > specific task.
> >
> > Signed-off-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/misc/Kconfig       |  11 ++++
> >   drivers/misc/Makefile      |   1 +
> >   drivers/misc/gpio-switch.c | 160 +++++++++++++++++++++++++++++++++++++++++++++
>
> Why isn't this in drivers/gpio/ ?
>
> why make it a misc driver?

I thought all the drivers in /drivers/gpio were gpio drivers, rather 
than users of the gpio framework. Is that not the case?

Happy to move it if the consensus is that that's the correct place to 
put it.

Martyn

> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/