RE: [Intel-wired-lan] [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

[Bowers, AndrewX]

I get an error -11 on driver init with this patch applied, I can revert it and everything works normally. Dmesg screenshot is attached, can supply complete dmesg log if needed.
--Andrew


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxxxxxxxx] On
> Behalf Of Andy Shevchenko
> Sent: Thursday, November 05, 2015 11:33 AM
> To: David Miller <davem@xxxxxxxxxxxxx>
> Cc: Sowmini Varadhan <sowmini.varadhan@xxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; netdev
> <netdev@xxxxxxxxxxxxxxx>
> Subject: Re: [Intel-wired-lan] [PATCH v6] i40e: Look up MAC address in Open
> Firmware or IDPROM
> 
> On Thu, Nov 5, 2015 at 8:31 PM, David Miller <davem@xxxxxxxxxxxxx>
> wrote:
> > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > Date: Thu, 5 Nov 2015 20:13:21 +0200
> >
> >> What about
> >>
> >> if (!addr)
> >>  return -ENODATA;
> >
> > I totally disagree.  of_get_phy_mode() and other similar attribute
> > probing mechanisms use -ENODEV.
> 
> Okay, then just
> if (!addr)
>  return -ENODEV;
> 
> --
> With Best Regards,
> Andy Shevchenko
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@xxxxxxxxxxxxxxxx
> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Attachment: dmesgerror.jpg
Description: dmesgerror.jpg