Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs

From: David Vrabel
Date: Thu Dec 03 2015 - 10:06:13 EST


On 03/12/15 11:23, Vitaly Kuznetsov wrote:
> David Vrabel <david.vrabel@xxxxxxxxxx> writes:
>
>> Adding the rtc platform device when there are no legacy irqs (no
>> legacy PIC)
>
> No PIC != No legacy IRQs, Hyper-V Gen2 represents such a platform (and
> it has RTC on irq8). I've tested this patch against it and it appears to
> work because the device is present in ACPI and we initialize it in
> drivers/acpi/acpi_cmos_rtc.c, add_rtc_cmos() bails out in the very
> beginning as we see PNP0b00 device.

It's not a legacy IRQ if it isn't going via the legacy PIC, it just
happens to have the same number.

I think it is safe to assume that any machine with a CMOS RTC but no PNP
information is also going to have a legacy PIC.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/