Re: [PATCH v2] acpi, apei, arm64: APEI initial support for aarch64.

[Fu Wei]

Hi Lorenzo,

On 3 December 2015 at 01:02, Lorenzo Pieralisi
<lorenzo.pieralisi@xxxxxxx> wrote:
> On Wed, Dec 02, 2015 at 10:59:05PM +0800, fu.wei@xxxxxxxxxx wrote:
>
> [...]
>
>> +#ifdef CONFIG_ACPI_APEI
>> +extern int acpi_disable_cmcff;
>> +#endif
>>
>>  static inline void disable_acpi(void)
>>  {
>> @@ -94,6 +97,7 @@ static inline const char *acpi_get_enable_method(int cpu)
>>
>>  #ifdef       CONFIG_ACPI_APEI
>>  pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr);
>> +void arch_apei_flush_tlb_one(unsigned long addr);
>>  #endif
>>
>>  #endif /*_ASM_ACPI_H*/
>> diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c
>> index d1ce8e2..811fea2 100644
>> --- a/arch/arm64/kernel/acpi.c
>> +++ b/arch/arm64/kernel/acpi.c
>> @@ -32,6 +32,7 @@
>>  #ifdef CONFIG_ACPI_APEI
>>  # include <linux/efi.h>
>>  # include <asm/pgtable.h>
>> +# include <asm/tlbflush.h>
>>  #endif
>>
>>  int acpi_noirq = 1;          /* skip ACPI IRQ initialization */
>> @@ -41,6 +42,10 @@ EXPORT_SYMBOL(acpi_disabled);
>>  int acpi_pci_disabled = 1;   /* skip ACPI PCI scan and IRQ initialization */
>>  EXPORT_SYMBOL(acpi_pci_disabled);
>>
>> +#ifdef CONFIG_ACPI_APEI
>> +int acpi_disable_cmcff;
>> +#endif
>
> There must be a reason why we keep all these arch agnostic ACPI flags
> in arch specific code, is there ?

very good point, will try to fix it in next patch  :-)

>
> Lorenzo
>
>> +
>>  static bool param_acpi_off __initdata;
>>  static bool param_acpi_force __initdata;
>>
>> @@ -233,4 +238,9 @@ pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr)
>>               return __pgprot(PROT_NORMAL_NC);
>>       return __pgprot(PROT_DEVICE_nGnRnE);
>>  }
>> +
>> +void arch_apei_flush_tlb_one(unsigned long addr)
>> +{
>> +     flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
>> +}
>>  #endif
>> --
>> 2.5.0
>>



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/