Re: [PATCH] kvm: remove unused variable 'vcpu_book3s'

From: Daniel Axtens
Date: Tue Dec 01 2015 - 19:35:20 EST


"Geyslan G. Bem" <geyslan@xxxxxxxxx> writes:

> The vcpu_book3s struct is assigned but never used. So remove it.

Just out of interest, how did you find this? Compiler warning? Static
analysis? Manual inspection?

Thanks in advance!

Regards,
Daniel

>
> Signed-off-by: Geyslan G. Bem <geyslan@xxxxxxxxx>
> ---
> arch/powerpc/kvm/book3s_64_mmu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
> index 774a253..9bf7031 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu.c
> @@ -377,15 +377,12 @@ no_seg_found:
>
> static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
> {
> - struct kvmppc_vcpu_book3s *vcpu_book3s;
> u64 esid, esid_1t;
> int slb_nr;
> struct kvmppc_slb *slbe;
>
> dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb);
>
> - vcpu_book3s = to_book3s(vcpu);
> -
> esid = GET_ESID(rb);
> esid_1t = GET_ESID_1T(rb);
> slb_nr = rb & 0xfff;
> --
> 2.6.2
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@xxxxxxxxxxxxxxxx
> https://lists.ozlabs.org/listinfo/linuxppc-dev

Attachment: signature.asc
Description: PGP signature