Re: [PATCH] net: add support for netdev notifier error injection

From: David Miller
Date: Tue Dec 01 2015 - 15:32:49 EST


From: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>
Date: Sat, 28 Nov 2015 13:45:28 +0100

> From: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>
>
> This module allows to insert errors in some of netdevice's notifier
> events. All network drivers use these notifiers to signal various events
> and to check if they are allowed, e.g. PRECHANGEMTU and CHANGEMTU
> afterwards. Until recently I had to run failure tests by injecting
> a custom module, but now this infrastructure makes it trivial to test
> these failure paths. Some of the recent bugs I fixed were found using
> this module.
> Here's an example:
> $ cd /sys/kernel/debug/notifier-error-inject/netdev
> $ echo -22 > actions/NETDEV_CHANGEMTU/error
> $ ip link set eth0 mtu 1024
> RTNETLINK answers: Invalid argument
>
> CC: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> CC: "David S. Miller" <davem@xxxxxxxxxxxxx>
> CC: netdev <netdev@xxxxxxxxxxxxxxx>
> Signed-off-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>

This looks fine, applied to net-next, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/