[bug] mei_fasync() bogosity

From: Al Viro
Date: Thu Nov 26 2015 - 23:23:15 EST


in "mei: implement fasync for event notification" a ->fasync() instance is
added as

static int mei_fasync(int fd, struct file *file, int band)
{

struct mei_cl *cl = file->private_data;

if (!mei_cl_is_connected(cl))
return POLLERR;

return fasync_helper(fd, file, band, &cl->ev_async);
}

Valid return values for ->fasync() are 0, 1 and -E...; 8 (aka POLLERR) is not.
What had been intended there? -ENODEV? Some other error? As it is, the
thing is broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/