Re: [PATCH 08/71] ncr5380: Move NCR53C400-specific code

From: Hannes Reinecke
Date: Thu Nov 19 2015 - 08:32:00 EST


On 11/18/2015 09:35 AM, Finn Thain wrote:
> Move board-specific code like this,
> NCR5380_write(C400_CONTROL_STATUS_REG, CSR_BASE);
> from the core driver to the board driver. Eliminate the NCR53C400 macro
> from the core driver. Removal of all macros like this one will be
> necessary in order to have one core driver that can support all kinds of
> boards.
>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
>
> ---
> drivers/scsi/NCR5380.c | 18 ------------------
> drivers/scsi/g_NCR5380.c | 23 ++++++++++++++++++-----
> drivers/scsi/g_NCR5380.h | 6 ++----
> 3 files changed, 20 insertions(+), 27 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/