Re: [PATCH] pci: completely disable aspm if it's unsupported

From: Matthew Garrett
Date: Wed Nov 18 2015 - 14:19:10 EST


On Wed, Nov 18, 2015 at 11:00 AM, Josef Bacik <jbacik@xxxxxx> wrote:
> It looks to me I'm doing what Matthew set out to do, only with a bigger
> hammer ;). His patch still allowed the initialization of the ASPM stuff,
> like setting up the clocks and such, but then made it so we couldn't change
> the ASPM state at all. My patch goes the step further of not even doing the
> initialization stuff. Thanks,

That sounds fine - if we don't gain _OSC control then we should avoid
touching any of the ASPM register state that the firmware has set. I'm
happy to call the current state broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/