Re: net-scm: Delete an unnecessary check before the function call "kfree"

[Daniel Borkmann]

On 11/17/2015 07:05 PM, SF Markus Elfring wrote:
> > Eric already mentioned that in some situations where it's critical,
> > it actually slows down the code, i.e. you'll have an extra
> > function call to get there and inside kfree() / kfree_skb() / etc,
> > the test is actually marked as unlikely().
>
> How do you think about to add similar annotations to any more
> source code places?

You mean this likely() annotation of yours? It doesn't make any sense
to me to place it there, and since you've spend the second thinking
about it when adding it to the diff, you should have already realized
that your code was buggy ...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/