Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC

[Andrew F. Davis]

On 11/17/2015 03:17 AM, Linus Walleij wrote:
> On Wed, Nov 4, 2015 at 6:12 PM, Andrew F. Davis <afd@xxxxxx> wrote:
>
> > Add support for the TPS65086 PMIC GPOs.
> >
> > TPS65086 has four configurable GPOs that can be used for several
> > purposes.
> >
> > Signed-off-by: Andrew F. Davis <afd@xxxxxx>
>
> OK...
>
> > +static int tps65086_gpio_get(struct gpio_chip *gc, unsigned offset)
> > +static void tps65086_gpio_set(struct gpio_chip *gc, unsigned offset,
>
> Just get/set and no get_direction/direction_input/direction_output?
> Are you sure?

Yeah, these are output only, I could probably add get_direction and just
always return output, but setters wouldn't make sense here.

Andrew

> Yours,
> Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/