Re: [PATCH] PCI: hisi: fix deferred probing

[Hanjun Guo]

On 11/13/2015 03:29 PM, Zhou Wang wrote:
> On 2015/11/12 20:21, Arnd Bergmann wrote:
> > The hisi_pcie_probe function is incorrectly marked as __init, as Kconfig
> > tells us:
> >
> > WARNING: drivers/pci/host/built-in.o(.data+0x7780): Section mismatch in reference from the variable hisi_pcie_driver to the function .init.text:hisi_pcie_probe()
> >
> > If the probe for this device gets deferred past the point where __init
> > functions are removed, or the device is unbound and then reattached to
> > the driver, we branch into uninitialized memory, which is bad.
> >
> > This removes the __init annotation.
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Hi Arnd,
>
> Many thanks, it looks good to me. so
> Acked-by: Zhou Wang <wangzhou1@xxxxxxxxxxxxx>

I found this problem too and prepared a patch for it, but
I noticed that Arnd already fixed it :)

Reviewed-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>

Thanks
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/