Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

[David Miller]

From: Mans Rullgard <mans@xxxxxxxxx>
Date: Mon, 16 Nov 2015 18:23:35 +0000

> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi)

"i" is passed in as a signed int here, but:

> +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len)
 ...
> +		err = nb8800_alloc_rx(dev, i, true);

It comes from an 'unsigned' value.

Please pick one type and use it consistently.

Also, always fully spell out "unsigned int" rather than use "unsigned"
as a shorthand.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/