Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool

From: David Rientjes
Date: Mon Nov 16 2015 - 05:05:56 EST


On Mon, 16 Nov 2015, Yaowei Bai wrote:

> diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> index 6523109..1da03f5 100644
> --- a/include/linux/gfp.h
> +++ b/include/linux/gfp.h
> @@ -375,12 +375,9 @@ static inline enum zone_type gfp_zone(gfp_t flags)
> * virtual kernel addresses to the allocated page(s).
> */
>
> -static inline int gfp_zonelist(gfp_t flags)
> +static inline bool gfp_zonelist(gfp_t flags)
> {
> - if (IS_ENABLED(CONFIG_NUMA) && unlikely(flags & __GFP_THISNODE))
> - return 1;
> -
> - return 0;
> + return IS_ENABLED(CONFIG_NUMA) && unlikely(flags & __GFP_THISNODE);
> }
>
> /*

This function is used to index into a pgdat's node_zonelists[] array, bool
makes no sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/