Re: [PATCH v5 2/7] usb: gadget: f_midi: remove duplicated code

From: Robert Baldyga
Date: Fri Nov 13 2015 - 03:09:42 EST


On 11/10/2015 06:52 PM, Felipe F. Tonello wrote:
> This code is duplicated from f_midi_start_ep(midi, f, midi->out_ep).
>
> Signed-off-by: Felipe F. Tonello <eu@xxxxxxxxxxxxxxxxx>

Reviewed-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>

> ---
> drivers/usb/gadget/function/f_midi.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
> index eeb989d..488111d 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -324,7 +324,6 @@ static int f_midi_start_ep(struct f_midi *midi,
> static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
> {
> struct f_midi *midi = func_to_midi(f);
> - struct usb_composite_dev *cdev = f->config->cdev;
> unsigned i;
> int err;
>
> @@ -340,24 +339,6 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
> if (err)
> return err;
>
> - usb_ep_disable(midi->out_ep);
> -
> - err = config_ep_by_speed(midi->gadget, f, midi->out_ep);
> - if (err) {
> - ERROR(cdev, "can't configure %s: %d\n",
> - midi->out_ep->name, err);
> - return err;
> - }
> -
> - err = usb_ep_enable(midi->out_ep);
> - if (err) {
> - ERROR(cdev, "can't start %s: %d\n",
> - midi->out_ep->name, err);
> - return err;
> - }
> -
> - midi->out_ep->driver_data = midi;
> -
> /* allocate a bunch of read buffers and queue them all at once. */
> for (i = 0; i < midi->qlen && err == 0; i++) {
> struct usb_request *req =
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/