Re: [PATCH] null_blk: Register as a LightNVM device

From: Christoph Hellwig
Date: Thu Nov 12 2015 - 10:52:36 EST


On Thu, Nov 12, 2015 at 08:49:08AM -0700, Jens Axboe wrote:
> But it still avoids duplicating the generics of it. Patch for null_blk:
>
> 3 files changed, 168 insertions(+), 7 deletions (-)
>
> vs a standalone of:
>
> 3 files changed, 459 insertions(+)
>
> It doesn't screw up null_blk, so I'd prefer just adding it as an on-the-side
> mode for that.

300 lines of boilerplate for just setting up a few request_queues seem
wrong, can you show the actual patch you measured?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/