Re: [RFC][PATCH] rcu: Clean up TASKS_RCU() abuse

From: Paul E. McKenney
Date: Wed Nov 11 2015 - 08:27:42 EST


On Wed, Nov 11, 2015 at 02:23:04PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 11, 2015 at 04:49:40AM -0800, Paul E. McKenney wrote:
> > On Wed, Nov 11, 2015 at 01:23:10PM +0100, Peter Zijlstra wrote:
> > > Hi
> > >
> > > I recently ran into TASKS_RCU() and wondered why we can't use normal
> > > coding patterns to do the same.
> > >
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> >
> > Well, I cannot get too excited either way, but the diffstat for this
> > change is not particularly favorable.
>
> It also doesn't build with TASKS_RCU enabled it turns out. But the point
> is, nowhere else do we use this pattern. We always provide functions.

RCU_TRACE() another very similar macro, and has been in place for quite
some time. Still within RCU, admittedly, but it does exist.

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/