RE: [PATCH v4 6/7] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

From: Jake Oshins
Date: Fri Oct 30 2015 - 12:13:50 EST


> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx]
> Sent: Thursday, October 29, 2015 5:45 PM
> To: Jake Oshins <jakeo@xxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; KY Srinivasan
> <kys@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; Vitaly
> Kuznetsov <vkuznets@xxxxxxxxxx>; tglx@xxxxxxxxxx; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; marc.zyngier@xxxxxxx; Jiang Liu
> <jiang.liu@xxxxxxxxxxxxxxx>; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; linux-
> pci@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 6/7] drivers:hv: Define the channel type for Hyper-V
> PCI Express pass-through
>
> >
> > /*
> > + * PCI Express Pass Through
> > + * {44C4F61D-4444-4400-9D52-802E27EDE19F}
> > + */
> > +
> > +#define HV_PCIE_GUID \
> > + .guid = { \
> > + 0x1D, 0xF6, 0xC4, 0x44, 0x44, 0x44, 0x00, 0x44, \
> > + 0x9D, 0x52, 0x80, 0x2E, 0x27, 0xED, 0xE1, 0x9F \
> > + }
>
> What about
> #include <linux/uuid.h>
>
> UUID_LE(...)
>
> And you may use uuid_le type instead of custom raw buffer.
>

Thanks. I was just following the form of all the others in this file. I think that this was done to match up with the representation that's coming across the VM boundary from Windows.

I do very much appreciate the feedback, though,
Jake Oshins