Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()"

[David Miller]

From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Tue, 27 Oct 2015 07:18:01 -0700

> On Tue, 2015-10-27 at 07:31 -0500, Josh Cartwright wrote:
> 
>> Okay, yes, I like the first suggestion better as well, I've included a
>> patch below that does just that.  I hope you don't mind me turning it
>> into a Suggested-by :).
>> 
>> Thanks for taking a look!
>>   Josh
> 
> 
>> @@ -6969,7 +6969,7 @@ EXPORT_SYMBOL(free_netdev);
>>  void synchronize_net(void)
>>  {
>>  	might_sleep();
>> -	if (rtnl_is_locked())
>> +	if (rtnl_is_locked() && !IS_ENABLED(CONFIG_PREEMPT_RT_FULL))
>>  		synchronize_rcu_expedited();
>>  	else
>>  		synchronize_rcu();
> 
> No objection from me. Thanks.
> 
> Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>

I agree with the sentiment to do the simple thing here first before
adding potentially useless knobs.

Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/