Re: [PATCH v2] blktrace: re-write setting q->blk_trace

From: Jens Axboe
Date: Thu Oct 29 2015 - 16:49:04 EST


On 10/30/2015 05:46 AM, Jeff Moyer wrote:
Jens Axboe <axboe@xxxxxxxxx> writes:

On 10/30/2015 04:19 AM, Davidlohr Bueso wrote:

The patch itself looks ok, but it doesn't seem to apply to a recent
kernel tree. It appears as though it is white-space damaged. Would you
mind re-sending it?

Hmm sorry about that. I thought I had based it against that day's
tip/master.
Anyway, here is v3 which is against tip/master as of
338e29ba93639138fafb9fb5ba946fd99a512aae.

Thanks, this is definitely cleaner. Your patch is still pretty
mangled, though. I had to hand apply it. Please check the result:

Heh, and here I just assumed the problem was on my end.

http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.4/core&id=cdea01b2bf98affb7e9c44530108a4a28535eee8

That looks fine, except you're missing the 'R' in Reviewed-by.

e-viewed. Electronically viewed by jeff?

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/