Re: [PATCH] get_maintainer: Add subsystem to reviewer output

[Joe Perches]

On Wed, 2015-10-28 at 17:01 +0000, Lee Jones wrote:
> On Wed, 28 Oct 2015, Joe Perches wrote:
> 
> > Reviewer output currently does not include the subsystem
> > that matched.  Add it.
> > 
> > Miscellanea:
> > 
> > o Add a get_subsystem_name routine to centralize this
> > 
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > ---
> >  scripts/get_maintainer.pl | 31 ++++++++++++++++---------------
> >  1 file changed, 16 insertions(+), 15 deletions(-)
> 
> It looks like I'm going to have to drop the patch where we actually
> start using the R: tag properly due to some social, emotional issues.

Not to mention logical.

> Despite that and not knowing Perl, I believe get_maintainer.pl should
> be printing out the subsystem next to 'reviewer' as it does for
> 'maintainer'.
> 
> So with that in mind:
>   Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

It'd be better if you could add a "tested-by:" instead.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/