Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

From: Lee Jones
Date: Wed Oct 28 2015 - 05:55:34 EST


On Wed, 28 Oct 2015, Uwe Kleine-KÃnig wrote:

> Hello,
>
> On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote:
> > On 28.10.2015 17:24, Lee Jones wrote:
> > > You guys are pushing back like this is some kind of demotion.
> > > That's not the case at all. All it does is better describe the (very
> > > worthy) function you *actually* provide.
> >
> > It is getting into dispute about entire change of yours... which is not
> > what I want. I agree with your general idea but I was referring only to
> > that particular case - the Samsung PMICs (and Maxim PMICs/MUICs which
> > would fall into same category).
>
> Not being affected by this change, I wonder what the technical
> difference is if someone is listed as reviewer instead of maintainer.
> Does get_maintainer.pl behave differently?

Reviewers are people who should be Cc'ed on all patches, as are
Maintainers, so no, fundamentally they are treated the same by a
Submitter.

Here is some output for Maintainers/Reviews from get_maintainer.pl.

$ ./scripts/get_maintainer.pl -f arch/arm/boot/dts/vf500.dtsi
Shawn Guo <shawnguo@xxxxxxxxxx> (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
Sascha Hauer <kernel@xxxxxxxxxxxxxx> (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
Stefan Agner <stefan@xxxxxxxx> (reviewer)
Russell King <linux@xxxxxxxxxxxxxxxx> (maintainer:ARM PORT)
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated list:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@xxxxxxxxxxxxxxx (open list)

I'm sure we can make the output even more similar by listing the
MAINTAINERS tag after "reviewer" too.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/