Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2

[Ray Jui]

On 10/27/2015 5:19 PM, Brian Norris wrote:
> On Fri, Oct 23, 2015 at 10:46:13AM +0530, Anup Patel wrote:
> > The NAND controller on NS2 SoC is compatible with existing
> > BRCM IPROC NAND driver so let's enable it in NS2 DT and
> > NS2 SVK DT.
> >
> > This patch also fixes use of node labels in ns2-svk.dts.
> >
> > Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxxxx>
> > Reviewed-by: Ray Jui <rjui@xxxxxxxxxxxx>
> > Reviewed-by: Scott Branden <sbranden@xxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/broadcom/ns2-svk.dts | 30 ++++++++++++++++++++----------
> >   arch/arm64/boot/dts/broadcom/ns2.dtsi    | 14 ++++++++++++++
> >   2 files changed, 34 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
> > index e5950d5..6bb3d4d 100644
> > --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts
> > +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
> > @@ -50,18 +50,28 @@
> >   		device_type = "memory";
> >   		reg = <0x000000000 0x80000000 0x00000000 0x40000000>;
> >   	};
> > +};
> >
> > -	soc: soc {
> > -		i2c0: i2c@66080000 {
> > -			status = "ok";
> > -		};
> > +&i2c0 {
> > +	status = "ok";
> > +};
> >
> > -		i2c1: i2c@660b0000 {
> > -			status = "ok";
> > -		};
> > +&i2c1 {
> > +	status = "ok";
> > +};
> > +
> > +&uart3 {
> > +	status = "ok";
> > +};
> >
> > -		uart3: serial@66130000 {
> > -			status = "ok";
> > -		};
> > +&nand {
> > +	nandcs@0 {
> > +		compatible = "brcm,nandcs";
> > +		reg = <0>;
> > +		nand-ecc-mode = "hw";
> > +		nand-ecc-strength = <8>;
> > +		nand-ecc-step-size = <512>;
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> >   	};
> >   };
> > diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi b/arch/arm64/boot/dts/broadcom/ns2.dtsi
> > index f603277..9610822 100644
> > --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi
> > +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi
> > @@ -212,5 +212,19 @@
> >   			compatible = "brcm,iproc-rng200";
> >   			reg = <0x66220000 0x28>;
> >   		};
> > +
> > +		nand: nand@66460000 {
> > +			compatible = "brcm,nand-iproc", "brcm,brcmnand-v6.1";
>
> Technically, the binding says you should also have "brcm,brcmnand" as a
> last resort. Otherwise (for the NAND parts):

I believe Anup was seeing issues when both "brcm,nand-iproc" and 
"brcm,brcmnand" are present.

Note "brcm,nand-iproc" invokes 'iproc_nand_probe', which calls 
'brcmnand_probe' in the end.

"brcm,brcmnand" invokes 'brcmstb_nand_probe', which also calls 
'brcmstb_probe', but without all the prep configuration required for 
"brcm,nand-iproc".

> Reviewed-by: Brian Norris <computersforpeace@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/