Re: [PATCH] kernel: power: replacing printk

From: Joe Perches
Date: Tue Oct 27 2015 - 15:00:49 EST


On Tue, 2015-10-27 at 09:46 +0530, Saurabh Sengar wrote:
> replacing prink(s) with appropriate pr_info and pr_err
[]
> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
[]
> @@ -486,9 +486,9 @@ static int enter_state(suspend_state_t state)
>
> #ifndef CONFIG_SUSPEND_SKIP_SYNC
> trace_suspend_resume(TPS("sync_filesystems"), 0, true);
> - printk(KERN_INFO "PM: Syncing filesystems ... ");
> + pr_info("PM: Syncing filesystems ... ");
> sys_sync();
> - printk("done.\n");
> + pr_info("done.\n");
> trace_suspend_resume(TPS("sync_filesystems"), 0, false);
> #endif
>

This isn't the same output.

The original code emits on a single line.

This new code emits on two lines, the second
line without a "PM: " prefix.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/