Re: [PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes

From: Peter Hurley
Date: Tue Oct 27 2015 - 14:24:22 EST


On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 172 bytes of machine code.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> CC: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx>
> CC: Jiri Slaby <jslaby@xxxxxxxx>
> CC: linux-serial@xxxxxxxxxxxxxxx
> ---
> drivers/tty/serial/fsl_lpuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index 08ce76f..ac26303 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -527,7 +527,7 @@ static inline void lpuart_prepare_rx(struct lpuart_port *sport)
> spin_unlock_irqrestore(&sport->port.lock, flags);
> }
>
> -static inline void lpuart_transmit_buffer(struct lpuart_port *sport)
> +static void lpuart_transmit_buffer(struct lpuart_port *sport)
> {
> struct circ_buf *xmit = &sport->port.state->xmit;

You'll want to run your script(s) on Greg's tty-next tree;
this file has copy+paste changes for 4.4 that added
lpuart32_transmit_buffer() as an inline function.

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/