Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources

From: Vivien Didelot
Date: Tue Oct 27 2015 - 13:07:23 EST


On Oct. Tuesday 27 (44) 04:43 PM, Neil Armstrong wrote:
> Hi,
> On 10/27/2015 04:39 PM, Florian Fainelli wrote:
> > On 27/10/15 07:48, Neil Armstrong wrote:
> >> Some switch drivers might request interrupts, remap register ranges,
> >> allow such drivers to implement a "remove" callback doing just that.
> >>
> >> Suggested-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> >
> > This should probably be a Signed-off-by tag, but there is nothing using
> > this, so you would want to introduce an user of this function in the
> > same patch series so we see how you intend to use it?
> >
> >> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>
> Yes, I didn't know how to handle this since it was part of a larger patch.
>
> I forgot to add this into the cover-letter but I wanted to send an RFC serie with
> your bcm remove patch and a mv88e6xxx remove experimental code.
>
> Yet, the mv88e6060 does not make usage of this.

So this patch must be part of your RFC for module removal instead of
this patchset.

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/