Re: [PATCH v3] serial: support 16-bit register interface for console

From: Peter Hurley
Date: Tue Oct 27 2015 - 09:53:14 EST


Hi Masahiro,

On 10/26/2015 12:11 AM, Masahiro Yamada wrote:
> Currently, 8-bit (MMIO) and 32-bit (MMIO32) register interfaces are
> supported for the 8250 console, but the 16-bit (MMIO16) is not.
> The 8250 UART device on my board is connected to a 16-bit bus
> and my main motivation is to use earlycon with it.
> (Refer to arch/arm/boot/dts/uniphier-support-card.dtsi)

As I noted in reviewing v2, the patch hunk below does not apply.
You must rebase your changes on top of Greg's tty-next tree.

Regards,
Peter Hurley

> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 603d2cc..325acce 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1819,8 +1819,8 @@ uart_get_console(struct uart_port *ports, int nr, struct console *co)
> * @options: ptr for <options> field; NULL if not present (out)
> *
> * Decodes earlycon kernel command line parameters of the form
> - * earlycon=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> - * console=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> + * earlycon=<name>,io|mmio|mmio16|mmio32|mmio32be,<addr>,<options>
> + * console=<name>,io|mmio|mmio16|mmio32|mmio32be,<addr>,<options>
> *
> * The optional form
> * earlycon=<name>,0x<addr>,<options>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/