Re: [PATCH] clk: versatile: Make depend on OF when COMPILE_TEST

From: Javier Martinez Canillas
Date: Mon Oct 26 2015 - 18:04:30 EST


Hello Stephen,

On 10/27/2015 03:51 AM, Stephen Boyd wrote:
> On 10/26, Javier Martinez Canillas wrote:
>> Commit 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is
>> enabled") allowed clk drives to be compile tested on other archs but
>
> s/drives/drivers/
>
>> the COMMON_CLK_VERSATILE was only enabled on platforms that already
>> selected OF support so the drivers assume it will always be enabled.
>>
>> So, restrict compile test for these drivers only if OF is enabled.
>
> No compiler error message?
>
>>
>> Fixes: 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is enabled")
>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>>
>
> No Reported-by?
>

Yes, sorry for forgetting the Reported-by and the build error...

> I'd prefer we add stubs instead, so I've applied the patch below.
>

Great, thanks!

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/