Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap

[Robert Jarzmik]

Lars-Peter Clausen <lars@xxxxxxxxxx> writes:

> On 10/24/2015 11:37 PM, Robert Jarzmik wrote:
> [...]
>> -static unsigned int ac97_read(struct snd_soc_codec *codec,
>> -	unsigned int reg);
>> -static int ac97_write(struct snd_soc_codec *codec,
>> -	unsigned int reg, unsigned int val);
>
> For review purposes it would be helpful to split this into two patches. One
> performing the regmap conversion the other replacing
> ac97_read()/ac97_write() with the matching snd_soc_ calls (or
> snd_soc_update_bits).
Most certainly, I'll do that. If bissection is not broken, it's fine by me.

>> +	snd_soc_codec_init_regmap(codec, regmap);
>
> You need to call snd_soc_odec_exit_regmap() when the CODEC is unbound.
Ah yes, I'll put that in the next iteration, thanks.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/