RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM

From: Luck, Tony
Date: Mon Oct 26 2015 - 12:46:44 EST


> + ((param2 & PAGE_MASK) != PAGE_MASK))
> return -EINVAL;
>
> The 3rd condition check makes sure that the param2 mask is the page size or less. So, I
> think we are OK on this.

Oops. The original was even on the screen as part of the diff (which I signed off on just two years ago).

I'd be happier if you made it the 1st condition though, so we skip calling region_intersects_*() with
a nonsense "size" argument.

-Tony