RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM

From: Luck, Tony
Date: Mon Oct 26 2015 - 12:27:09 EST


- pfn = PFN_DOWN(param1 & param2);
- if (!page_is_ram(pfn) || ((param2 & PAGE_MASK) != PAGE_MASK))
+ base_addr = param1 & param2;
+ size = (~param2) + 1;

We expect the user will supply us with param2 in the form 0xffffffff[fec8]00000
with various numbers of leading 'f' and trailing '0' ... but I don't think we actually
check that anywhere. But we have a bunch of places that assume it is OK, including
this new one.

It's time to fix that. Maybe even provide a default 0xfffffffffffff000 so I can save myself
some typing?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/