[PATCH v2 2/2] serial: 8250_early: squash wait_for_xmitr() into serial_putc()

From: Masahiro Yamada
Date: Sat Oct 24 2015 - 00:19:15 EST


Now, wait_for_xmitr() is only called from serial_putc(), and both
are short enough. They can be merged into a single function.

Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
---

drivers/tty/serial/8250/8250_early.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
index 559b681..19aca19 100644
--- a/drivers/tty/serial/8250/8250_early.c
+++ b/drivers/tty/serial/8250/8250_early.c
@@ -76,21 +76,17 @@ static void __init serial8250_early_out(struct uart_port *port, int offset, int

#define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE)

-static void __init wait_for_xmitr(struct uart_port *port)
+static void __init serial_putc(struct uart_port *port, int c)
{
unsigned int status;

for (;;) {
status = serial8250_early_in(port, UART_LSR);
if ((status & BOTH_EMPTY) == BOTH_EMPTY)
- return;
+ break;
cpu_relax();
}
-}

-static void __init serial_putc(struct uart_port *port, int c)
-{
- wait_for_xmitr(port);
serial8250_early_out(port, UART_TX, c);
}

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/