RE: [PATCH] GHES: Fix cached error-status

From: Luck, Tony
Date: Fri Oct 23 2015 - 19:05:24 EST


> ping?

I'm not actually sure that the code is wrong. As you say it is a pretty strange loop.

We seem to want to look at a bunch of conditions, and use "continue" to ignore
bits until we find one that we like the look of. Perhaps as soon as we do, we want
to believe it to get our return value? Perhaps the code knows that we won't find
another section that matches all the tests, so it isn't worth going around the loop
again.

Ying: You wrote this code 4 years ago. Any recollections of why it looks like it does?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/