Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

[Alexei Starovoitov]

On 10/22/15 7:21 PM, Wangnan (F) wrote:
> > +    if (attr->inherit)
> > +        goto err;
> > +
>
> Since Peter suggest it is pointless for a system-wide perf_event
> has inherit bit set [1], I think it should be safe to enable
> system-wide perf_event pass this check?

here we don't know whether it's system wide or not, so the check
is needed.
The patch is the fix that should have been there from day one.
We must be safe first and relax later.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/