Re: [PATCH 2/2] perf tools: Improve call graph documents and help messages

From: Arnaldo Carvalho de Melo
Date: Thu Oct 22 2015 - 12:26:36 EST


Em Fri, Oct 23, 2015 at 01:05:45AM +0900, Namhyung Kim escreveu:
> On Thu, Oct 22, 2015 at 11:46 PM, Arnaldo Carvalho de Melo
> > At some point it would be nice to be able to use:
> >
> > perf top --call-graph caller
> >
> > And have that be equivalent to:
> >
> > perf top --callgraph fp,graph,0.5,caller,function
> >
> > I.e. change just one of the defaults.

> ?? That's supported already by commit e8232f1ad468 ("perf report:
> Relax -g option parsing not to limit the option order")..

Ok, that "point" already happened, good! ;-)

> > But I think that how you did it is backwards compatible, i.e. adding
> > stuff just to the end.

> > Ah, noticed you forgot to update the 'top' man page
>
> Heh, I just added below in the previous patch.. ;-)
>
> "See `--call-graph` section in perf-record and perf-report man pages
> for details."

Okay then, should be enough :-)

> Thanks,
> Namhyung
>
> /me goes to bed now...

G'nite!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/