Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

[Arnaldo Carvalho de Melo]

Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu:
> On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > Hi Ingo,
> >
> > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >>
> >> * Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >>
> >>> The caller callchain order is useful with --children option since it can
> >>> show 'overview' style output, but other commands which don't use
> >>>  --children feature like 'perf script' or even 'perf report/top' without
> >>>  --children are better to keep caller order.
> >
> > Oops, there's a typo:  s/caller order/callee order/ :)
> 
> Thanks, I was wondering about that (and I've made that typo myself).
> Thanks for the patch!

Brendan, can I take that as an Acked-by?
 
> Brendan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/