Re: [PATCHv12 14/37] futex, thp: remove special case for THP in get_futex_key

From: Artem Savkov
Date: Thu Oct 22 2015 - 06:33:52 EST


On Thu, Oct 22, 2015 at 12:49:45PM +0300, Kirill A. Shutemov wrote:
> On Thu, Oct 22, 2015 at 10:24:33AM +0200, Artem Savkov wrote:
> > On Tue, Oct 06, 2015 at 06:23:41PM +0300, Kirill A. Shutemov wrote:
> > > With new THP refcounting, we don't need tricks to stabilize huge page.
> > > If we've got reference to tail page, it can't split under us.
> > >
> > > This patch effectively reverts a5b338f2b0b1.
> > >
> > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> > > Tested-by: Sasha Levin <sasha.levin@xxxxxxxxxx>
> > > Tested-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx>
> > > Acked-by: Jerome Marchand <jmarchan@xxxxxxxxxx>
> > > ---
> > > kernel/futex.c | 61 ++++++++++++----------------------------------------------
> > > 1 file changed, 12 insertions(+), 49 deletions(-)
> >
> > This patch breaks compound page futexes with the following panic:
>
> Thanks for report. Patch below fixes the issue for me.
> Could you test it as well?
>
Yep, this patch does fix the problem for me as well.

--
Regards,
Artem
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/