Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper

[Alexei Starovoitov]

On 10/21/15 10:31 PM, Wangnan (F) wrote:
> > +    if ((attr->type != PERF_TYPE_RAW &&
> > +         !(attr->type == PERF_TYPE_SOFTWARE &&
> > +           attr->config == PERF_COUNT_SW_BPF_OUTPUT) &&
> > +         attr->type != PERF_TYPE_HARDWARE) ||
> > +        attr->inherit) {
>
> This 'if' statement is so complex. What about using a inline function
> instead?

hmm. don't see how inline function will help readability.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/